[PATCH 1/2] gdb: push target earlier in procfs_target::attach (PR 27435)

[Simon Marchi]

On 2021-02-21 4:04 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Simon> Tested by trying to attach on a process on gcc211 on the gcc compile
> Simon> farm.
> 
> Simon> gdb/ChangeLog:
> 
> Simon> 	PR gdb/27435
> Simon> 	* inf-ptrace.c (struct target_unpusher): Move to target.h.
> Simon> 	(target_unpush_up): Likewise.
> Simon> 	* procfs.c (procfs_target::attach): Push target early.  Use
> Simon> 	target_unpush_up to unpush target in case of error.
> Simon> 	* target.h (struct target_unpusher): Move here.
> Simon> 	(target_unpush_up): Likewise.
> 
> FWIW this looks reasonable to me.
> 
> Tom

Thanks, I'll wait for Libor's feedback before pushing.

Simon