[PATCH 6/8] Add new gdbarch generator

Tom Tromey tom@tromey.com
Thu Dec 16 18:56:46 GMT 2021


Simon> I think it would be nice to do a pass of adding comments in gdbarch.py,
Simon> for those who will come after us (or future us).  I can do it if you'd
Simon> like.

I will do it.

Simon> flake8 pointed these out, it's mostly just style, but would be nice to
Simon> fix:

I fixed these.

There are some flake8 errors in gdbarch-components.py, but I didn't fix
those.  Most of them are due to how the file is loaded by gdbarch.py,
and the remaining few are over-long comment lines that are pre-existing
buglets in gdbarch.sh, I think.

Simon> I don't have much else to say, I feel like nitpicking on this script
Simon> would be a high level of bike-shedding.  Thank you very much for picking
Simon> this up and completing it!

I don't mind tweaks, but we can also of course make changes afterward.

>> +class Method(Function):
>> +    def param_list(self):
>> +        return self.set_list()
>> +
>> +    def actuals(self, initial_comma=True):

Simon> initial_comma is unused

Fixed.

Tom


More information about the Gdb-patches mailing list