[PATCH 22/29] gdb/testsuite: Remove duplicates from gdb.base/funcargs.exp

[Pedro Alves]

On 2021-12-16 23:08, Lancelot SIX wrote:
> On Fri, Dec 10, 2021 at 11:26:23PM +0000, Pedro Alves wrote:
>> On 2021-11-21 17:56, Lancelot SIX via Gdb-patches wrote:
>>> --- a/gdb/testsuite/gdb.base/funcargs.exp
>>> +++ b/gdb/testsuite/gdb.base/funcargs.exp
>>> @@ -213,7 +213,7 @@ proc complex_args {} {
>>>  
>>>      # Run; should stop at call1a and print actual arguments.
>>>      gdb_run_cmd
>>> -    gdb_test "" " callca \\(f1=1 \\+ 2i, f2=1 \\+ 2i, f3=1 \\+ 2i\\) .*" "run to call2a"
>>> +    gdb_test "" " callca \\(f1=1 \\+ 2i, f2=1 \\+ 2i, f3=1 \\+ 2i\\) .*" "run to call2a (complex_arg)"
>>
>> No tail parens, please.  See:
>>
>> https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Do_not_use_.22tail_parentheses.22_on_test_messages
> 
> Sorry, I did forget about this.
> 
> I have changed the way I refactor this code.  Mode of the tests are
> already grouped into procs, so I replace plain procs with
> proc_with_prefix.  It also makes it easier to find the problematic
> portion of the file when a FAIL pop up.

I like it, thanks.  This is OK.