[PATCHv2 0/5] refactoring towards Python MI command API

Andrew Burgess aburgess@redhat.com
Tue Dec 14 11:56:59 GMT 2021


I updated with the feedback from Simon, and pushed this series.

Thanks,
Andrew


* Andrew Burgess <aburgess@redhat.com> [2021-12-03 16:29:55 +0000]:

> I originally posted these patches here:
> 
>   https://sourceware.org/pipermail/gdb-patches/2021-November/183231.html
> 
> but as that was buried in the middle of a general discussion thread I
> was worried the series might not have been noticed.
> 
> The work in those patches is not my own, but is based on Jan's work
> which has been previously posted here:
> 
>   https://sourceware.org/pipermail/gdb-patches/2019-May/158010.html
> 
> This series is not all of Jan's work, his series goes all of the way
> to adding a Python API for creating MI commands.  This series is just
> the refactoring ahead of the final Python changes, but I think these
> changes stand on their own, so would like to have them considered for
> acceptance.  We can then rebase the remained of Jan's work on top of
> master once this series lands.
> 
> Pedro had some feedback on Jan's V3 series, but only one of the
> feedback items applies to the work I'm submitting here:
> 
>   https://sourceware.org/pipermail/gdb-patches/2019-June/158431.html
> 
> I've gone thought that email and I believe that all of the issues
> listed have been addressed.
> 
> Changes since _my_ V1 series:
> 
>   - rebased onto current upstream master, and
> 
>   - ensured that all of Pedro's feedback has been addressed.
> 
> Any additional feedback would be welcome.
> 
> Thanks,
> Andrew
> 
> 
> ---
> 
> Andrew Burgess (1):
>   gdb/mi: int to bool conversion in mi_execute_cli_command
> 
> Jan Vrany (4):
>   gdb/mi: rename mi_lookup to mi_cmd_lookup
>   gdb/mi: use std::map for MI commands in mi-cmds.c
>   gdb/mi: use separate classes for different types of MI command
>   gdb/mi: rename mi_cmd to mi_command
> 
>  gdb/mi/mi-cmd-info.c |   4 +-
>  gdb/mi/mi-cmds.c     | 571 ++++++++++++++++++++++++-------------------
>  gdb/mi/mi-cmds.h     |  70 ++++--
>  gdb/mi/mi-main.c     |  51 +---
>  gdb/mi/mi-main.h     |  12 +
>  gdb/mi/mi-parse.c    |  20 +-
>  gdb/mi/mi-parse.h    |   6 +-
>  7 files changed, 401 insertions(+), 333 deletions(-)
> 
> -- 
> 2.25.4
> 



More information about the Gdb-patches mailing list