[PATCH 19/29] gdb/testsuite: Remove duplicates from gdb.base/exprs.exp

Pedro Alves pedro@palves.net
Fri Dec 10 23:15:13 GMT 2021


On 2021-11-21 17:56, Lancelot SIX via Gdb-patches wrote:
> When running the testsuite, I have:
> 
>     Running .../gdb/testsuite/gdb.base/exprs.exp ...
>     DUPLICATE: gdb.base/exprs.exp: \$[0-9]* = red (setup)
> 
> Fix by using with_test_prefix where appropriate.
> 
> Tested on x86_64-linux.
> ---
>  gdb/testsuite/gdb.base/exprs.exp | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/gdb/testsuite/gdb.base/exprs.exp b/gdb/testsuite/gdb.base/exprs.exp
> index 50272d133a2..0525f76a44c 100644
> --- a/gdb/testsuite/gdb.base/exprs.exp
> +++ b/gdb/testsuite/gdb.base/exprs.exp
> @@ -238,7 +238,9 @@ test_expr "print \"x\" \"y\" \"z\"" "\\$\[0-9\]* = \"xyz\""
>  # Enum formatting tests.
>  test_expr "print red" "\\$\[0-9\]* = red"
>  gdb_test "set output-radix 8" ".*"
> -test_expr "print red" "\\$\[0-9\]* = red"
> +with_test_prefix "with output-radix 8" {
> +    test_expr "print red" "\\$\[0-9\]* = red"
> +}
>  test_expr "print/d red" "\\$\[0-9\]* = 0"

The following test_expr is also under output-radix 8.  This seems to be begging for:

with_test_prefix "output-radix 8" {
  gdb_test "set output-radix 8" ".*"
  test_expr "print red" "\\$\[0-9\]* = red"
  test_expr "print/d red" "\\$\[0-9\]* = 0"
  gdb_test "set output-radix 10" ".*"
}

WDYT?

>  
> 



More information about the Gdb-patches mailing list