[PATCH][gdb/testsuite] Support .debug_aranges in dwarf assembly

Tom Tromey tom@tromey.com
Fri Aug 27 13:35:17 GMT 2021


>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> +    #   arange [-c <comment>] [<segment selector>] <start> <length>
Tom> +    #     -- adds an address range.

I wonder if there's a way to make this more tcl-ish, say by rearranging
the order of arguments so that things can be defaulted.  I think the
"args"-parsing style should normally be a last resort.

Tom> +	proc arange { args } {

This is nested in 'aranges', but that's weird style in Tcl.
It redefines the proc every time 'aranges' is invoked.
I think it's better to just namespace scope this.

Tom


More information about the Gdb-patches mailing list