[PATCH v2] gdb: riscv_scan_prologue: handle LD and LW instructions

Andrew Burgess andrew.burgess@embecosm.com
Fri Aug 13 09:14:53 GMT 2021


* Lancelot SIX <lsix@lancelotsix.com> [2021-08-12 23:44:19 +0000]:

> On Thu, Aug 12, 2021 at 11:26:38PM +0000, Lancelot SIX via Gdb-patches wrote:
> > > 
> > > LGTM.
> > > 
> > > Thanks for doing this.
> > > 
> > > Andrew
> > > 
> > 
> > I just pushed it.
> > 
> > Lancelot.
> 
> Actually, I just realized that one of the testfile was not properly
> named.  It is probably not critical, keep it tidy, I’ll rename the .c
> file to match the name of the testcase.
> 
> Is the following patch OK?

LGTM.  Sorry for not catching this.

Thanks,
Andrew

> 
> ---
> From bda6d870e1202ceb113de369b8a109d495b8d4d7 Mon Sep 17 00:00:00 2001
> From: Lancelot SIX <lsix@lancelotsix.com>
> Date: Thu, 12 Aug 2021 23:29:08 +0000
> Subject: [PATCH] gdb: rename
>  gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-ld-lw.c
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> A previous commit added the
> gdb.arch/riscv64-unwind-prologue-with-ld-lw.exp testcase, but one of its
> associated file was named after a previous version of the test.
> 
> This commit fixes this and makes sure that all the files linked to this
> testcase share the same prefix in the name.
> 
> Tested on riscv64 GNU/Linux.
> ---
>  ...-prologue-with-ld.c => riscv64-unwind-prologue-with-ld-lw.c} | 0
>  gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-ld-lw.exp   | 2 +-
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename gdb/testsuite/gdb.arch/{riscv64-unwind-prologue-with-ld.c => riscv64-unwind-prologue-with-ld-lw.c} (100%)
> 
> diff --git a/gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-ld.c b/gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-ld-lw.c
> similarity index 100%
> rename from gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-ld.c
> rename to gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-ld-lw.c
> diff --git a/gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-ld-lw.exp b/gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-ld-lw.exp
> index c329d2f72e0..f559c3ff4bc 100644
> --- a/gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-ld-lw.exp
> +++ b/gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-ld-lw.exp
> @@ -21,7 +21,7 @@ if {![istarget "riscv64-*-*"]} {
>      return
>  }
>  
> -standard_testfile riscv64-unwind-prologue-with-ld.c \
> +standard_testfile riscv64-unwind-prologue-with-ld-lw.c \
>  		  riscv64-unwind-prologue-with-ld-lw-foo.s
>  if {[prepare_for_testing "failed to prepare" $testfile \
>  			 "$srcfile $srcfile2"  nodebug]} {
> -- 
> 2.30.2


More information about the Gdb-patches mailing list