[PATCH 15/43] Make DWARF evaluator return a single struct value

Simon Marchi simon.marchi@polymtl.ca
Wed Apr 28 14:24:44 GMT 2021


> I've just copied this whole block from the loc.c. Everything is replaced with a new implementation in the later patch.
> 
> Do you still feel that I need to clean it up here or it doesn't really matter considering the later patches?

Up to you.  Keep in mind that I give comments that make sense by looking
at the individual patches, without much context of what's coming after.
For a change of this size, it would be too difficult for me to make
comments considering the patchset as a whole, it just wouldn't fit in my
head.  So if some code gets removed down the road and doing the change
isn't really useful, it's ok to say that and ignore the comment.

Simon


More information about the Gdb-patches mailing list