[pushed] gdb: fix formatting of serial::async_state's enumerators

Simon Marchi simon.marchi@polymtl.ca
Mon Sep 28 18:22:07 GMT 2020


The comments related to these enumerators are placed under the
corresponding enumerator.  This is quite unusual and confusing.  Change
it to have the comments above, as usual.

gdb/ChangeLog:

	* ser-base.c: Adjust comments formatting.

Change-Id: If2ea143a7d5217efa5ac088102ddb1933fbcb16a
---
 gdb/ChangeLog  |  4 ++++
 gdb/ser-base.c | 13 +++++++------
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 7a73f9a047f9..c99fce06919f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2020-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
+
+	* ser-base.c: Adjust comments formatting.
+
 2020-09-27  Tom Tromey  <tom@tromey.com>
 
 	PR tui/25342:
diff --git a/gdb/ser-base.c b/gdb/ser-base.c
index fb6f4e056ad5..84ca8c6167cb 100644
--- a/gdb/ser-base.c
+++ b/gdb/ser-base.c
@@ -43,17 +43,18 @@ static handler_func fd_event;
 
 /* Value of scb->async_state: */
 enum {
-  /* >= 0 (TIMER_SCHEDULED) */
-  /* The ID of the currently scheduled timer event.  This state is
-     rarely encountered.  Timer events are one-off so as soon as the
-     event is delivered the state is changed to NOTHING_SCHEDULED.  */
-  FD_SCHEDULED = -1,
+  /* When >= 0, this contains the ID of the currently scheduled timer event.
+     This state is rarely encountered.  Timer events are one-off so as soon as
+     the event is delivered the state is changed to NOTHING_SCHEDULED.  */
+
   /* The fd_event() handler is scheduled.  It is called when ever the
      file descriptor becomes ready.  */
-  NOTHING_SCHEDULED = -2
+  FD_SCHEDULED = -1,
+
   /* Either no task is scheduled (just going into ASYNC mode) or a
      timer event has just gone off and the current state has been
      forced into nothing scheduled.  */
+  NOTHING_SCHEDULED = -2
 };
 
 /* Identify and schedule the next ASYNC task based on scb->async_state
-- 
2.28.0



More information about the Gdb-patches mailing list