[PATCH 2/6] Move simple_search_memory to target/search.c
Tom Tromey
tromey@adacore.com
Fri Sep 25 19:02:05 GMT 2020
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
Simon> On 2020-07-23 4:12 p.m., Tom Tromey wrote:
>> This moves the simple_search_memory function to a new file,
>> target/search.c. The API is slightly changed to make it more general.
>> This generality is useful for wiring it to gdbserver, and also for
>> unit testing.
Simon> What's the rationale for putting this under gdb/target/ instead
Simon> of gdbsupport/?
I think originally I thought this code would rely on the target API, but
I see it does not. I'll move it.
Simon> I never really understood the point of target/. It looks like the goal is to
Simon> share interfaces between gdb and gdbserver, having declarations in header files
Simon> in target/ and having different implementations in gdb and gdbserver.
Yeah, at least sometimes I think.
Tom
More information about the Gdb-patches
mailing list