[pushed] gdb: remove file_handler typedef

Simon Marchi simon.marchi@polymtl.ca
Thu Sep 24 19:20:31 GMT 2020


From: Simon Marchi <simon.marchi@efficios.com>

Remove the typedef (unneeded with C++).  Re-format the comments to
follow the more common style.

gdbsupport/ChangeLog:

	* event-loop.c (struct file_handler): Remove typedef, re-format.

Change-Id: I3aea21fba1eb2584c507de3412da4e4c98283b2d
---
 gdbsupport/ChangeLog     |  4 ++++
 gdbsupport/event-loop.cc | 35 +++++++++++++++++++++++------------
 2 files changed, 27 insertions(+), 12 deletions(-)

diff --git a/gdbsupport/ChangeLog b/gdbsupport/ChangeLog
index d46f8c77bb02..a2f563c81c0d 100644
--- a/gdbsupport/ChangeLog
+++ b/gdbsupport/ChangeLog
@@ -1,3 +1,7 @@
+2020-09-24  Simon Marchi  <simon.marchi@efficios.com>
+
+	* event-loop.c (struct file_handler): Remove typedef, re-format.
+
 2020-09-16  John Baldwin  <jhb@FreeBSD.org>
 
 	* common.m4 (GDB_AC_COMMON): Refactor checks for kinfo_getfile().
diff --git a/gdbsupport/event-loop.cc b/gdbsupport/event-loop.cc
index e959e1b91b8d..59436d467ede 100644
--- a/gdbsupport/event-loop.cc
+++ b/gdbsupport/event-loop.cc
@@ -44,18 +44,29 @@
 /* Information about each file descriptor we register with the event
    loop.  */
 
-typedef struct file_handler
-  {
-    int fd;			/* File descriptor.  */
-    int mask;			/* Events we want to monitor: POLLIN, etc.  */
-    int ready_mask;		/* Events that have been seen since
-				   the last time.  */
-    handler_func *proc;		/* Procedure to call when fd is ready.  */
-    gdb_client_data client_data;	/* Argument to pass to proc.  */
-    int error;			/* Was an error detected on this fd?  */
-    struct file_handler *next_file;	/* Next registered file descriptor.  */
-  }
-file_handler;
+struct file_handler
+{
+  /* File descriptor.  */
+  int fd;
+
+  /* Events we want to monitor: POLLIN, etc.  */
+  int mask;
+
+  /* Events that have been seen since the last time.  */
+  int ready_mask;
+
+  /* Procedure to call when fd is ready.  */
+  handler_func *proc;
+
+  /* Argument to pass to proc.  */
+  gdb_client_data client_data;
+
+  /* Was an error detected on this fd?  */
+  int error;
+
+  /* Next registered file descriptor.  */
+  struct file_handler *next_file;
+};
 
 /* Do we use poll or select ? */
 #ifdef HAVE_POLL
-- 
2.28.0



More information about the Gdb-patches mailing list