[PATCH 3/3] Remove call of GenerateConsoleCtrlEvent

Eli Zaretskii eliz@gnu.org
Thu Sep 24 14:40:32 GMT 2020


> From: Simon Marchi <simark@simark.ca>
> Date: Wed, 23 Sep 2020 23:35:10 -0400
> 
> On 2020-09-23 1:21 p.m., Hannes Domani via Gdb-patches wrote:
> > GenerateConsoleCtrlEvent returns TRUE even if no ctrl-c event was created
> > in the target process (like if the target doesn't have a console).
> >
> > Since this prevents DebugBreakProcess from being called (which should
> > always work), this removes it.
> 
> Eli, does that make sense to you?  Just judging from the explanation
> above, it sounds fine to me.

The explanation sounds fine, but I don't know enough about the
details to say something intelligent.  This seems to have some
non-trivial context that I lack to understand, for example, why the
fact that "GenerateConsoleCtrlEvent returns TRUE even if no ctrl-c
event was created in the target process" is a problem.

But it's okay to disregard my ignorance and go ahead with pushing
this.


More information about the Gdb-patches mailing list