[PATCH] Don't drop static function bp locations w/o debug info

[Luis Machado]

The new tests are failing for aarch64-linux-gnu on Ubuntu 18.04 (GCC 7.5.0).

The breakpoint location patterns don't seem to be matching. Here's what 
I see...

info breakpoint^M
Num     Type           Disp Enb Address            What^M
1       breakpoint     keep y   <MULTIPLE>         ^M
1.1                         y   0x0000000000000794 <foo@plt+4>^M
1.2                         y   0x00000000000008bc <foo>^M
(gdb) FAIL: gdb.base/msym-bp-shl.exp: debug=0: before run: info breakpoint

info breakpoint^M
Num     Type           Disp Enb Address            What^M
3       breakpoint     keep y   <MULTIPLE>         ^M
3.1                         y   0x0000aaaaaaaaa8bc <foo>^M
3.2                         y   0x0000ffffb7fc065c <foo>^M
(gdb) FAIL: gdb.base/msym-bp-shl.exp: debug=0: at main: info breakpoint

info breakpoint^M
Num     Type           Disp Enb Address            What^M
1       breakpoint     keep y   <MULTIPLE>         ^M
1.1                         y   0x00000000000006e4 <foo>^M
1.2                         y   0x00000000000006f4 <foo>^M
(gdb) FAIL: gdb.base/msym-bp.exp: debug=0: before run: info breakpoint

info breakpoint^M
Num     Type           Disp Enb Address            What^M
3       breakpoint     keep y   <MULTIPLE>         ^M
3.1                         y   0x0000aaaaaaaaa6e4 <foo>^M
3.2                         y   0x0000aaaaaaaaa6f4 <foo>^M
(gdb) FAIL: gdb.base/msym-bp.exp: debug=0: at main: info breakpoint

Anything obvious?

On 9/13/20 10:25 AM, Pedro Alves wrote:
> On 6/12/20 8:53 PM, Simon Marchi wrote:
>> On 2020-06-12 3:21 p.m., Pedro Alves wrote:
>>> @@ -4371,21 +4336,54 @@ search_minsyms_for_name (struct collect_info *info,
>>>   
>>>     if (!minsyms.empty ())
>>
>> You could remove this check and de-indent the rest.  If minsyms is empty, the loop
>> will just be skipped over.
>>
>> Otherwise, LGTM.
> 
> Thanks, I did that, and merged it now.
> 
> Pedro Alves
>