[PATCH 1/2] Split gdb.multi/multi-target.exp into separate testcases

Simon Marchi simark@simark.ca
Thu Sep 17 19:41:16 GMT 2020


On 2020-09-17 2:00 p.m., Pedro Alves wrote:
> gdb.multi/multi-target.exp sets up a debug environment with multiple
> gdbservers, multiple native processes, and multiple cores, which has
> proved useful for exercising a number of multi-target scenarios.
>
> But, as we add more tests to gdb.base/multi-target.exp, it is growing
> a bit too large (making a bit cumbersome to debug) and too slow to run
> (if you have glibc debug info).
>
> This commit thus splits the multi-target.exp into several testcases,
> one per use case.  The common setup code is moved to a new
> multi-target.exp.tcl file that is included by all the resulting
> multi-target testcases.
>
> gdb/testsuite/ChangeLog:
>
> 	* gdb.multi/mtarg-continue.exp: New file, factored out from
> 	multi-target.exp.
> 	* gdb.multi/mtarg-info-inferiors.exp: New file, factored out from
> 	multi-target.exp.
> 	* gdb.multi/mtarg-interrupt.exp: New file, factored out from
> 	multi-target.exp.
> 	* gdb.multi/mtarg-no-resumed.exp: New file, factored out from
> 	multi-target.exp.
> 	* gdb.multi/mtarg-ping-pong-next.exp: New file, factored out from
> 	multi-target.exp.
> 	* gdb.multi/multi-target.exp.tcl: New file, factored out from
> 	multi-target.exp.
> 	* gdb.multi/multi-target.exp: Delete.

Maybe a small comment here: I think it would be clearer to not
abbreviate "multi-target" to "mtarg", so to name the files
"multi-target-foo.exp".  Abbreviations like that are a bit intimidating
when you are not familiar with them.

Simon


More information about the Gdb-patches mailing list