[committed][gdb/testsuite] Fix unbalanced braces in gdb.tui/new-layout.exp
Tom de Vries
tdevries@suse.de
Wed Sep 16 08:58:01 GMT 2020
Hi,
On SLE-11 with tcl version 8.5, we run into:
...
UNRESOLVED: gdb.tui/new-layout.exp: testcase aborted due to \
invalid command name: }
ERROR: Couldn't send tui new-layout example src 1} to GDB.
...
Apparently tcl 8.6 is more forgiving about unbalanced braces.
Expose the unbalanced braces on tcl 8.6 by temporarily wrapping the
test-case in:
...
proc do_this { args } {
uplevel 1 {*}$args
}
do_this {
...
}
...
and escape them using a backslash.
Tested on x86_64-linux.
Committed to trunk.
Thanks,
- Tom
[gdb/testsuite] Fix unbalanced braces in gdb.tui/new-layout.exp
gdb/testsuite/ChangeLog:
2020-09-16 Tom de Vries <tdevries@suse.de>
PR testsuite/26618
* gdb.tui/new-layout.exp: Escape unbalanced braces.
---
gdb/testsuite/gdb.tui/new-layout.exp | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/gdb/testsuite/gdb.tui/new-layout.exp b/gdb/testsuite/gdb.tui/new-layout.exp
index b4fca674e8..57c3f75e3b 100644
--- a/gdb/testsuite/gdb.tui/new-layout.exp
+++ b/gdb/testsuite/gdb.tui/new-layout.exp
@@ -42,12 +42,12 @@ gdb_test "tui new-layout example src 1 src 1" \
"Window \"src\" seen twice in layout"
gdb_test "tui new-layout example src 1" \
"New layout does not contain the \"cmd\" window"
-gdb_test "tui new-layout example src 1}" \
- "Extra '}' in layout specification"
-gdb_test "tui new-layout example {src 1} 1}" \
- "Extra '}' in layout specification"
-gdb_test "tui new-layout example {src 1" \
- "Missing '}' in layout specification"
+gdb_test "tui new-layout example src 1\}" \
+ "Extra '\}' in layout specification"
+gdb_test "tui new-layout example {src 1} 1\}" \
+ "Extra '\}' in layout specification"
+gdb_test "tui new-layout example \{src 1" \
+ "Missing '\}' in layout specification"
gdb_test_no_output "tui new-layout example asm 1 status 0 cmd 1"
More information about the Gdb-patches
mailing list