[PATCH v2 15/16] Don't change current program space in exec_target::close

Tom Tromey tom@tromey.com
Mon Oct 19 21:44:28 GMT 2020


Now that we've removed the macros and moved various functions to be
methods on program_space (removing uses of current_program_space),
it's clear that exec_target::close can operate on program spaces
without changing the current program space.

gdb/ChangeLog
2020-10-19  Tom Tromey  <tom@tromey.com>

	* exec.c (exec_target::close): Don't change current program
	space.
---
 gdb/ChangeLog | 5 +++++
 gdb/exec.c    | 3 ---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/gdb/exec.c b/gdb/exec.c
index 3736c3c9e67..3092e8fc3a6 100644
--- a/gdb/exec.c
+++ b/gdb/exec.c
@@ -154,11 +154,8 @@ exec_target_open (const char *args, int from_tty)
 void
 exec_target::close ()
 {
-  scoped_restore_current_program_space restore_pspace;
-
   for (struct program_space *ss : program_spaces)
     {
-      set_current_program_space (ss);
       ss->target_sections.clear ();
       ss->exec_close ();
     }
-- 
2.17.2



More information about the Gdb-patches mailing list