[PATCH 1/4] Remove init_psymbol_list
Tom Tromey
tom@tromey.com
Sat Oct 17 22:50:53 GMT 2020
init_psymbol_list is now empty, and so this removes it.
gdb/ChangeLog
2020-10-17 Tom Tromey <tom@tromey.com>
* dbxread.c (dbx_symfile_read): Update.
* dwarf2/read.c (dwarf2_build_psymtabs): Update.
* xcoffread.c (xcoff_initial_scan): Update.
* psympriv.h (init_psymbol_list): Don't declare.
* psymtab.c (init_psymbol_list): Remove.
---
gdb/ChangeLog | 8 ++++++++
gdb/dbxread.c | 3 ---
gdb/dwarf2/read.c | 2 --
gdb/psympriv.h | 6 ------
gdb/psymtab.c | 7 -------
gdb/xcoffread.c | 6 ------
6 files changed, 8 insertions(+), 24 deletions(-)
diff --git a/gdb/dbxread.c b/gdb/dbxread.c
index 4665cddc5f1..4e189a7f127 100644
--- a/gdb/dbxread.c
+++ b/gdb/dbxread.c
@@ -535,9 +535,6 @@ dbx_symfile_read (struct objfile *objfile, symfile_add_flags symfile_flags)
if (val < 0)
perror_with_name (objfile_name (objfile));
- /* Size the symbol table. */
- init_psymbol_list (objfile, DBX_SYMCOUNT (objfile));
-
symbol_size = DBX_SYMBOL_SIZE (objfile);
symbol_table_offset = DBX_SYMTAB_OFFSET (objfile);
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index 37409c5c3fc..c5bfab19059 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -6117,8 +6117,6 @@ dwarf2_build_psymtabs (struct objfile *objfile)
return;
}
- init_psymbol_list (objfile, 1024);
-
try
{
/* This isn't really ideal: all the data we allocate on the
diff --git a/gdb/psympriv.h b/gdb/psympriv.h
index 97f9b3b596c..73077ebac7f 100644
--- a/gdb/psympriv.h
+++ b/gdb/psympriv.h
@@ -436,12 +436,6 @@ struct legacy_psymtab : public standard_psymtab
void *read_symtab_private = nullptr;
};
-/* Initialize storage for partial symbols. If partial symbol storage
- has already been initialized, this does nothing. TOTAL_SYMBOLS is
- an estimate of how many symbols there will be. */
-
-extern void init_psymbol_list (struct objfile *objfile, int total_symbols);
-
extern void end_psymtab_common (struct objfile *, struct partial_symtab *);
/* Used when recording partial symbol tables. On destruction,
diff --git a/gdb/psymtab.c b/gdb/psymtab.c
index acccfca9d91..349c68ed55e 100644
--- a/gdb/psymtab.c
+++ b/gdb/psymtab.c
@@ -1584,13 +1584,6 @@ partial_symtab::add_psymbol (gdb::string_view name, bool copy_name,
/* See psympriv.h. */
-void
-init_psymbol_list (struct objfile *objfile, int total_symbols)
-{
-}
-
-/* See psympriv.h. */
-
partial_symtab::partial_symtab (const char *filename_, struct objfile *objfile)
: searched_flag (PST_NOT_SEARCHED),
text_low_valid (0),
diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c
index 3588aaed016..075ebee7012 100644
--- a/gdb/xcoffread.c
+++ b/gdb/xcoffread.c
@@ -2922,12 +2922,6 @@ xcoff_initial_scan (struct objfile *objfile, symfile_add_flags symfile_flags)
if (val != size)
perror_with_name (_("reading symbol table"));
- /* I'm not sure how how good num_symbols is; the rule of thumb in
- init_psymbol_list was developed for a.out. On the one hand,
- num_symbols includes auxents. On the other hand, it doesn't
- include N_SLINE. */
- init_psymbol_list (objfile, num_symbols);
-
scoped_free_pendings free_pending;
minimal_symbol_reader reader (objfile);
--
2.17.2
More information about the Gdb-patches
mailing list