[PATCH] gdb: improve command completion for 'print', 'x', and 'display'

[Tom Tromey]

>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:

Pedro> I assumed it was on purpose that those weren't used, since you've
Pedro> included safe-ctype.h and are (rightfully IMO) using ISSPACE and not 
Pedro> isspace.  skip_spaces/skip_to_space use isspace not ISSPACE.
Pedro> Probably doesn't make a difference in practice.  Not sure there's
Pedro> any locale where isspace/ISSPACE return a different result.
Pedro> ISSPACE is cheaper, so maybe we should make skip_spaces/skip_to_space
Pedro> use it.

skip_* are intended for use by gdb commands -- they originally lived in
gdb/cli/ -- so if they do the wrong thing in some situation, they should
definitely be changed.

Tom