[PATCH] gdb: improve command completion for 'print', 'x', and 'display'

Tom Tromey tom@tromey.com
Wed Nov 18 16:11:56 GMT 2020


>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> The /FMT specification on the print command currently breaks command
Andrew> completion, so:

Note that this is PR cli/16256

Andrew> +      if (ISALNUM (text[1]) || ISSPACE(text[1]))

Missing space before a paren here.

Andrew> +	{
Andrew> +	  /* Skip over the actual format specification.  */
Andrew> +	  while (*text != '\0' && !ISSPACE (*text))
Andrew> +	    ++text;

There's skip_spaces and skip_to_space for this kind of thing..

Andrew> +	      while (ISSPACE (*text))
Andrew> +		++text;

..and this.

Thank you for doing this.

Tom


More information about the Gdb-patches mailing list