[PATCH] gdb/testsuite: do not hard-code location indices in condbreak-multi-context.exp

Aktemur, Tankut Baris tankut.baris.aktemur@intel.com
Tue Nov 17 10:49:35 GMT 2020


On Monday, November 16, 2020 1:00 PM, Gary Benson wrote:
> Hi Baris,
> 
> Your patch fixes the issues I experienced.  Thank you for fixing this
> so quickly, and please accept my apologies for having taken so long to
> review this.

Thanks for checking, Gary.

Simon, OK to check in?

-Baris

> > On Friday, October 30, 2020 4:07 PM, Aktemur, Tankut Baris wrote:
> > > Breakpoint locations are sorted according to their addresses.  The
> > > addresses are determined by how the compiler emits the code.
> > > Therefore, we may have a different order of locations depending on the
> > > compiler we use.  To make the gdb.base/condbreak-multi-context.exp
> > > test flexible enough for different compilers' output, do not hard-code
> > > location indices.
> > >
> > > Tested with GCC and Clang.
> > >
> > > gdb/testsuite/ChangeLog:
> > > 2020-10-30  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
> > >
> > > 	* gdb.base/condbreak-multi-context.exp: Do not hard-code location
> > > 	indices.


Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


More information about the Gdb-patches mailing list