[PATCH] Fix frame cycle detection (Re: [PATCH 3/3] Make scoped_restore_current_thread's cdtors exception free (RFC))

[Pedro Alves]

On 11/16/20 1:48 PM, Tom de Vries wrote:
> On 11/9/20 3:05 PM, Aktemur, Tankut Baris via Gdb-patches wrote:
>> On Saturday, October 31, 2020 3:35 PM, Pedro Alves wrote:
>>> On 10/30/20 11:32 AM, Pedro Alves wrote:
>>>> Hi!
>>>>
>>>> On 10/30/20 7:44 AM, Aktemur, Tankut Baris wrote:
>>>>
>>>>> Hi Pedro,
>>>>>
>>>>> This patch created the regression below:
>>>>>
>>>>>   Breakpoint 1, 0x00000000004012bb in eh2 (/gdb-up/gdb/frame.c:641: internal-error:
>>> frame_id get_frame_id(frame_info*): Assertion `stashed' failed.
>>>>>   A problem internal to GDB has been detected,
>>>>>   further debugging may prove unreliable.
>>>>>   Quit this debugging session? (y or n) FAIL: gdb.base/eh_return.exp: hit breakpoint (GDB
>>> internal error)
>>>>
>>>> Hmm, sorry about that.  It passes for me on the machine I was
>>>> running tests on, so I missed it.  I can reproduce it on a F27 machine.
>>>> I'll take a better look.
>>>>
>>>
>>> Here's a fix.  See explanation within.
>>
>> Thanks.  This fixed the regression.
>>
> 
> I can also confirm that this fixes the FAIL for me.  Glad I committed
> that test-case :)

Indeed.  :-)  Thanks for the confirmations.  I've merged this now.

Pedro Alves