[PATCH 0/5] remove some manual reference counting

Joel Brobecker brobecker@adacore.com
Sun Nov 8 10:07:41 GMT 2020


Hi Tom,

> I think manual reference counting should generally be avoided in favor
> of smart pointers.  This series converts a few such spots in gdb.
> 
> Regression tested on x86-64 Fedora 28.

I went through the patches, and it's a nice improvement, as well
as another good demo of the advantages of C++ over pure C.

For me, the patches look good. I should say, though, that my C++
knowledge is a little shaky, and there are probably better reviewers
out there itching to review this series ;-). The first 3-4 ones
are relatively straightforward for me. The last one is a little
more involved, but it looks reasonable and it makes sense to me.

-- 
Joel


More information about the Gdb-patches mailing list