[PATCHv2 3/7] hurd: make function cast stronger

Simon Marchi simark@simark.ca
Sat May 30 14:47:50 GMT 2020


On 2020-05-29 6:01 p.m., Samuel Thibault wrote:
> Fixes
> 
> process_reply_S.c:104:23: error: function called through a non-compatible type [-Werror]
>   104 |      OutP->RetCode = (*(kern_return_t (*)(mach_port_t, kern_return_t)) S_proc_setmsgport_reply) (In0P->Head.msgh_request_port, In0P-
> 
> gdb/ChangeLog:
> 
> 2020-05-29  Samuel Thibault  <samuel.thibault@ens-lyon.org>
> 
> 	* reply_mig_hack.awk (Error return): Cast function through
> 	void *, to bypass compiler function call check.

If you are silencing a compiler warning, please explain why it is safe to do so.  Why
are we calling a function in a non-compatible way, is it a warning false positive?
Because just like that, it just sounds like we are passing the wrong arguments and it
should not be fixed by just silencing the warning, but by fixing the call.

Simon


More information about the Gdb-patches mailing list