[PATCH 1/2] gdb/testsuite: add simavr.exp board

Simon Marchi simon.marchi@polymtl.ca
Mon May 25 15:57:43 GMT 2020


On 2020-05-25 10:44 a.m., Pedro Alves wrote:
>> Here's the patch with that fixed:
> 
> Don't you want to handle timeout (and maybe unexpected output) in
> the new gdb_expect call?

It's a good idea to add a timeout.  I added this line:

  timeout { error "unable to connect to simavr stub" }

If for some reason we can't connect (I tested it by purposely expecting the wrong string),
it will throw and abort the test promptly with an error.  Without the timeout, the test
continues pointlessly and it takes ages because we wait for many tests to time out.

> Regardless, this LGTM.  It doesn't impact anything else and can always be
> improved afterwards.

Thanks, I pushed the series with that fixed.  If you find anything else to improve, don't
hesitate to suggest it, I can fix it up later.

Simon


More information about the Gdb-patches mailing list