Pushed to gdb-9-branch: [PUSHED/OBVIOUS] Fix base class function call

Joel Brobecker brobecker@adacore.com
Sat May 23 16:31:30 GMT 2020


Hi Christian (and Simon),

On Wed, Feb 05, 2020 at 11:52:57AM -0600, Christian Biesinger via gdb-patches wrote:
> This was a typo introduced in f6ac5f3d63e03a81c4ff3749aba234961cc9090e.
> 
> Found by looking through NetBSD's GDB patches:
> https://github.com/NetBSD/pkgsrc-wip/blob/master/gdb-netbsd/patches/patch-gdb_sparc-nat.h
> 
> This patch can't be tested on Linux because Linux does not use the
> sparc_target template.
> 
> gdb/ChangeLog:
> 
> 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
> 
> 	* sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
> 	function call.

As a user stumbled onto the error that this commit fixes, and the correction
is indeed quite obvious, I created a new PR for this issue, and then
backported the patch to the gdb-9-branch:

    https://sourceware.org/bugzilla/show_bug.cgi?id=26029

> 
> Change-Id: I4fa88cbdc365efe89b84cc0619b60db38718d9ce
> ---
>  gdb/sparc-nat.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/sparc-nat.h b/gdb/sparc-nat.h
> index 1dbdd80b5e..d07bd86d03 100644
> --- a/gdb/sparc-nat.h
> +++ b/gdb/sparc-nat.h
> @@ -75,8 +75,8 @@ struct sparc_target : public BaseTarget
>        return sparc_xfer_wcookie (object, annex, readbuf, writebuf,
>  				 offset, len, xfered_len);
>  
> -    return BaseTarget (object, annex, readbuf, writebuf,
> -		       offset, len, xfered_len);
> +    return BaseTarget::xfer_partial (object, annex, readbuf, writebuf,
> +				     offset, len, xfered_len);
>    }
>  };
>  
> -- 
> 2.25.0.341.g760bfbb309-goog

-- 
Joel


More information about the Gdb-patches mailing list