[RFC][PATCH 6/7] Convert short jumps to long ones in amd64_relocate_instruction
Tom Tromey
tom@tromey.com
Fri May 22 19:41:48 GMT 2020
>>>>> ">" == paul-naert via Gdb-patches <gdb-patches@sourceware.org> writes:
>> + if (newrel < INT32_MIN || newrel > INT32_MAX)
>> + {
>> + /* Overflowing the 32 bit jump */
>> + if (debug_displaced)
>> + error (_ ("Overflowing of int32 for jump instruction relocation"));
>> + }
It seems like the error ought not be conditional on debug_displaced.
Wouldn't this result in silently doing something incorrect?
Tom
More information about the Gdb-patches
mailing list