Use bfd_get_filename throughout gdb

[Simon Marchi]

On 2020-05-19 12:12 a.m., Alan Modra via Gdb-patches wrote:
> ref: https://sourceware.org/pipermail/binutils/2020-May/111154.html
> 
> This patch makes gdb use the inline accessor for all bfd->filename
> read accesses.
> 
> OK to apply after the 9.2 release happens?

Hi Alan,

This is ok to push to the master branch.  The 9.2 release happens from the gdb-9-branch
anyway.

This doesn't prevent new code from using the field (in some of my pending patches,
I'm pretty sure I have some code that accesses it).  Short of being able to make the
field private, have you thought of leaving the field's name changed?  Perhaps adopting
a naming convention that says "this field is private" and adding a comment above it to
say "don't access this directly, use bfd_get_filename"?

Simon