[PATCH 1/6] Add column information of dwarf to the symbol information

Luis Machado luis.machado@linaro.org
Tue May 19 12:23:55 GMT 2020


On 5/18/20 1:17 PM, Tom Tromey wrote:
> Hannes>  void
> Hannes>  buildsym_compunit::record_line (struct subfile *subfile, int line,
> Hannes> -				CORE_ADDR pc, bool is_stmt)
> Hannes> +				CORE_ADDR pc, bool is_stmt, int column)
> 
> I think putting the column parameter next to the line parameter would be
> more idiomatic.
> 
> Tom
> 

Should we avoid passing line/column separately and, instead, pass down a 
struct containing both? They're part of the same high level information 
(the position in the source file). That would be cleaner IMO.


More information about the Gdb-patches mailing list