[PATCH 2/2] gdb: Preserve is-stmt lines when switch between files

[Andrew Burgess]

* Tom Tromey <tom@tromey.com> [2020-05-14 14:18:44 -0600]:

> >>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
> 
> Resurrecting this again ... we have some internal tests that have been
> failing, and I want to land at least one of these patches to resolve
> this.
> 
> Andrew> After reading[2] I'd also be interest to understand what flaw in
> Andrew> DWARF you feel makes a difference in this case.
> 
> I also don't understand this.
> 
> Andrew> I think it is great Bernd, that you are reaching out from the GCC
> Andrew> community to engage with GDB, this is certainly the best way to ensure
> Andrew> that we can work together as communities to give the best possible
> Andrew> debug experience, and I'm sorry you feel that I have not been clear
> Andrew> enough about the issues I'm seeing here.
> 
> +1
> 
> Andrew>   I don't know how we address this without merging your patch,
> Andrew>   releasing GDB and seeing how it works in the wild.  However, if we
> Andrew>   did decide to "just try it", I would still prefer we staged things
> Andrew>   as:
> Andrew>     (a) Merge my patch, targeted regression fix, then
> Andrew>     (b) Your patch, new functionality GCC/DWARF ranges work around.
> Andrew>   In this way, if we end up backing out some or all of (b) we still
> Andrew>   have (a) in place that fixes the regression.  I'm more than happy
> Andrew>   for a rebase of (b) in include full removal of (a).
> 
> I think landing your patch is safe to do while we discuss part (b).
> How about we move forward with that part?  Then if we come to agreement
> on where the bug lies we can decide about that.

I agree. I already rebased this and retested it.  Unless someone
shouts out between now and tomorrow I plan to merge my patch.

Bernd (or anyone else) - I'm more than happy that if a better patch is
put forward it can revert some or all of my patch, as needed.  Like
Tom, I'd like to see the regressions squashed.

Thanks,
Andrew