[RFA 08/10] Fix/improve 'apropos' output

Tom Tromey tom@tromey.com
Thu May 14 16:30:21 GMT 2020


>>>>> "Philippe" == Philippe Waroquiers via Gdb-patches <gdb-patches@sourceware.org> writes:

Philippe> YYYY-MM-DD  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

Philippe> 	* cli/cli-decode.c (apropos_cmd): Produce output for aliases
Philippe> 	when their aliased command is traversed.
Philippe> 	(help_cmd): Add fput_command_names_styled call to
Philippe> 	output command name and aliases when command has an alias.

Philippe> gdb/testsuite/ChangeLog

Philippe> YYYY-MM-DD  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

Philippe> 	* gdb.base/help.exp: Test apropos and help for commands
Philippe> 	having aliases.

Thanks.

Philippe> +	  /*  Command aliases/abbreviations are skipped to ensure we print the
Philippe> +	      doc of a command only once, when encountering the aliased
Philippe> +	      command.  */

The leading indent in the comment looks weird.

Philippe> +# test apropos for commands having aliases.
Philippe> +gdb_test "apropos Print backtrace of all stack frames, or innermost COUNT frames\." \
Philippe> +    "backtrace, where, bt -- Print backtrace of all stack frames, or innermost COUNT frames\."
Philippe> +
Philippe> +# test help for commands having aliases.
Philippe> +gdb_test "help bt" "backtrace, where, bt\[\r\n\]+Print backtrace of all stack frames, or innermost COUNT frames\..*"

The new comments here should start with an upper-case letter.

Ok with those nits fixed.

Tom


More information about the Gdb-patches mailing list