[RFA 07/10] Fix/improve 'help CLASS' output
Tom Tromey
tom@tromey.com
Thu May 14 16:26:46 GMT 2020
>>>>> "Philippe" == Philippe Waroquiers via Gdb-patches <gdb-patches@sourceware.org> writes:
Philippe> The output layout chosen is to have the command first, followed by all its
Philippe> aliases separated by a comma. Note that the command and alias names are
Philippe> title-styled. For sure, other layouts could be discussed, but this one is IMO
Philippe> readable and compact.
I think it's good this way.
Philippe> +static void help_cmd_list (struct cmd_list_element *list, enum command_class theclass,
This line looks to be too long.
Philippe> - help_cmd_list (list, theclass, cmdtype, (int) theclass >= 0, stream);
Philippe> + help_cmd_list (list, theclass, (int) theclass >= 0, stream);
I think you might as well remove the "(int)" cast while you're touching
this line. I don't believe it's needed.
Otherwise this looks good to me.
Tom
More information about the Gdb-patches
mailing list