[RFA 04/10] command-def-selftests.c: detect missing or wrong prefix cmd in subcommands.

Tom Tromey tom@tromey.com
Thu May 14 15:54:58 GMT 2020


>>>>> "Philippe" == Philippe Waroquiers via Gdb-patches <gdb-patches@sourceware.org> writes:

Thank you for the patch.

Philippe> This test reveals a number of problems fixed in the next commit.

It's best (IME) to develop in this order, but then to either combine the
test and the fix, or to put the fix before the test when submitting.
The reason for this is that it helps avoid failures when bisecting.

Philippe> +  SELF_CHECK (nr_invalid_prefixcmd == 0);

This code should reset nr_invalid_prefixcmd as well.

Tom


More information about the Gdb-patches mailing list