[PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES

Aaron Merey amerey@redhat.com
Tue May 5 21:23:35 GMT 2020


On Tue, May 5, 2020 at 12:41 PM Jeff Law <law@redhat.com> wrote:
>
> On Fri, 2020-05-01 at 22:29 -0400, Aaron Merey via Gcc-patches wrote:
> > Hello,
> >
> > I'm not sure if this is the right mailing list for this patch but it modifies
> > the top level directory of binutils-gdb for which I understand GCC to be the
> > upstream. The purpose of this patch is to use PKG_CHECK_MODULES in
> > config/debuginfod.m4 since debuginfod supports pkg-config. Otherwise the
> > functionality of debuginfod.m4 is not changed by this patch. The rest of the
> > changes involve renaming a debuginfod autoconf variable, removing an
> > unnecessary call to AC_DEBUGINFOD in the top level configure.ac and the
> > regeneration of files in gdb/, binutils/ and the top-level directory.
> >
> > Aaron Merey
> >
> >
> > From 31c1e42fb7185080a21673b8818dca01fc7d4d6f Mon Sep 17 00:00:00 2001
> > From: Aaron Merey <amerey@redhat.com>
> > Date: Fri, 1 May 2020 21:51:43 -0400
> > Subject: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES
> >
> > Use PKG_CHECK_MODULES to set the debuginfod autoconf vars.
> >
> > ChangeLog:
> >
> >         * config/debuginfod.m4: use PKG_CHECK_MODULES.
> >         * configure: Rebuild.
> >         * configure.ac: Remove AC_DEBUGINFOD.
> >
> > ChangeLog/binutils:
> >
> >         * Makefile.am: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS.
> >         * Makefile.in: Rebuild.
> >         * aclocal.m4: Rebuild.
> >         * configure: Rebuild.
> >         * doc/Makefile.in: Rebuild.
> >
> > ChangeLog/gdb:
> >
> >         * Makefile.in: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS.
> >         * aclocal.m4: Rebuild.
> >         * configure: Rebuild.
> I can't ack the binutils or gdb directories.  But the toplevel and config/ bits
> are fine.  Do you have commit privs to the GCC repo?  Do all these have to go in
> together?  If so, that means we should coordinate commits and resyncing gcc, gdb
> and binutils

I do not have commit privs to the GCC repo. It's better if all parts
are committed
at once to keep the files consistent.

I've reattached the patch and cc'd gdb-patches. Binutils and GDB folks, do
you have any concerns with this patch?

Thanks,
Aaron
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-config-debuginfod.m4-Use-PKG_CHECK_MODULES.patch
Type: text/x-patch
Size: 71772 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/gdb-patches/attachments/20200505/9debe9a2/attachment-0001.bin>


More information about the Gdb-patches mailing list