[patch v3] Fix cyrillic symbols show in tui.

[Simon Marchi]

On 2020-04-27 1:14 p.m., Tom Tromey wrote:
>>>>>> ">" == Vaag via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
>>> From: Vahagn Vardanyan <vaag@ispras.ru>
>>> Cyrillic symbols are truncated when assigned to signed char
>>> and are shown as special symbols in tui.
>>> The patch uses unsigned char to allow 256 bit encoding.
> 
>>> gdb/ChangeLog
> 
>>>         * tui/tui-winsource.c (tui_copy_source_line):
>>>         Change type from char to unsigned char.
>>>         * tui/tui-io.c (do_tui_putc):
>>>         Use waddstr instead of waddch.
> 
> Could you try this instead?
> 
> https://sourceware.org/pipermail/gdb-patches/2020-April/167397.html
> 
> It's slightly buggy and needs another tweak but, I think, is more
> complete than the approach you took.  In particular it ought to work if
> a multi-byte character extends past the window boundary.
> 
> If that works for you in a preliminary way, I'll clean it up.

Hi Tom,

A colleague of mine complained about the lack of emoji support in the TUI,
so it reminded me of this patch :).

I read and tried the patch you proposed at the link above, and it works fine
for me.  I would appreciate a bit more comments to make the intents a bit more
explicit, but otherwise it looks good to me.

What is still buggy about it?

Simon