[PATCHv2 2/2] gdb: Add support for tracking the DWARF line table is-stmt field

[Bernd Edlinger]

On 3/17/20 7:23 PM, Tom Tromey wrote:
> Tom> Actually, when I back out the hunk, I get:
> Tom>     Breakpoint 1 at 0x80000042: file r.h, line 6.
> Tom> However, in the past it appears this mentioned the function name.
> 
> I think I'm mistaken about this, so IMO we can just drop this part and
> focus on whether we should remove that buildsym.c hunk.
> 

Agreed, I'd just remove that for now

--- a/gdb/buildsym.c
+++ b/gdb/buildsym.c
@@ -683,20 +683,6 @@ struct blockvector *
       m_have_line_numbers = true;
     }
 
-  if (subfile->line_vector->nitems > 0)
-    {
-      /* If we have a duplicate for the previous entry then ignore the new
-        entry, except, if the new entry is setting the is_stmt flag, then
-        ensure the previous entry respects the new setting.  */
-      e = subfile->line_vector->item + subfile->line_vector->nitems - 1;
-      if (e->line == line && e->pc == pc)
-       {
-         if (is_stmt && !e->is_stmt)
-           e->is_stmt = 1;
-         return;
-       }
-    }
-

Andrew?

> thanks,
> Tom
>