[PATCH] gdb.fortran: Allow Flang kind printing in fortran testing

[Andrew Burgess]

* Sharma, Alok Kumar <AlokKumar.Sharma@amd.com> [2020-03-02 17:27:58 +0000]:

> 
> diff --git a/gdb/testsuite/lib/fortran.exp b/gdb/testsuite/lib/fortran.exp
> index 54f3293677..549ed65790 100644
> --- a/gdb/testsuite/lib/fortran.exp
> +++ b/gdb/testsuite/lib/fortran.exp
> @@ -32,9 +32,10 @@ proc set_lang_fortran {} {
>  proc fortran_int4 {} {
>      if {[test_compiler_info {gcc-4-[012]-*}]} {
>  	return "int4"
> -    } elseif {[test_compiler_info {gcc-*}]
> -	      || [test_compiler_info {clang-*}]} {
> +    } elseif {[test_compiler_info {gcc-*}]} {
>  	return "integer\\(kind=4\\)"
> +    } elseif {[test_compiler_info {clang-*}]} {
> +	return "integer"

The clang-* line that is being removed was added by this commit:

  commit c3b149eb7697b376df1b3a47d0102afda389ee6d
  Author: Alok Kumar Sharma <alokkumar.sharma@amd.com>
  Date:   Tue Feb 4 17:17:20 2020 +0000

      gdb/fortran: Allow for using Flang in Fortran testing

So I wonder what the story is here?  Do different versions of Flang
print the values differently? Should we be checking for specific Flang
versions like we do with GCC, or was the first patch just wrong?
Which would be absolutely fine, it would just be nice if the commit
message explained why this patch is changing something that was only
committed a month ago.

Thanks,
Andrew