Breakage on builder Fedora-x86_64-native-extended-gdbserver-m32, revision 0240c8f11b06a33a043bacbe2b9e723ae6ad573c

[gdb-buildbot@sergiodj.net]

Unfortunately it seems that there is a breakage on GDB.

Commit title: 'Change how TUI windows are instantiated'
Revision: 0240c8f11b06a33a043bacbe2b9e723ae6ad573c

You can find more details below:

+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+


+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.

  CXX    sparc64-sol2-tdep.o
  CXX    sparc64-tdep.o
  CXX    stabsread.o
  CXX    stack.o
  CXX    stap-probe.o
  CXX    std-regs.o
  CXX    symfile-debug.o
  CXX    symfile-mem.o
  CXX    symfile.o
  CXX    symmisc.o
  CXX    symtab.o
  CXX    target-connection.o
  CXX    target-dcache.o
  CXX    target-descriptions.o
  CXX    target-float.o
  CXX    target-memory.o
  CXX    target.o
  CXX    target/waitstatus.o
  CXX    test-target.o
  CXX    thread-iter.o
  CXX    thread.o
  CXX    tic6x-linux-tdep.o
  CXX    tic6x-tdep.o
  CXX    tid-parse.o
  CXX    tilegx-linux-tdep.o
  CXX    tilegx-tdep.o
  CXX    top.o
  CXX    tracectf.o
  CXX    tracefile-tfile.o
  CXX    tracefile.o
  CXX    tracepoint.o
  CXX    trad-frame.o
  CXX    tramp-frame.o
  CXX    tui/tui-command.o
  CXX    tui/tui-data.o
  CXX    tui/tui-disasm.o
  CXX    tui/tui-file.o
  CXX    tui/tui-hooks.o
  CXX    tui/tui-interp.o
  CXX    tui/tui-io.o
  CXX    tui/tui-layout.o
  CXX    tui/tui-out.o
  CXX    tui/tui-regs.o
../../binutils-gdb/gdb/tui/tui-layout.c:354:40: error: window_factory was not declared in this scope
  354 | static std::unordered_map<std::string, window_factory> *known_window_types;
      |                                        ^~~~~~~~~~~~~~
../../binutils-gdb/gdb/tui/tui-layout.c:354:54: error: template argument 2 is invalid
  354 | static std::unordered_map<std::string, window_factory> *known_window_types;
      |                                                      ^
../../binutils-gdb/gdb/tui/tui-layout.c:354:54: error: template argument 5 is invalid
../../binutils-gdb/gdb/tui/tui-layout.c: In function tui_gen_win_info* tui_get_window_by_name(const string&):
../../binutils-gdb/gdb/tui/tui-layout.c:361:31: error: saved_tui_windows was not declared in this scope; did you mean all_tui_windows?
  361 |   for (tui_win_info *window : saved_tui_windows)
      |                               ^~~~~~~~~~~~~~~~~
      |                               all_tui_windows
../../binutils-gdb/gdb/tui/tui-layout.c:365:35: error: request for member find in * known_window_types, which is of non-class type int
  365 |   auto iter = known_window_types->find (name);
      |                                   ^~~~
../../binutils-gdb/gdb/tui/tui-layout.c:366:35: error: request for member end in * known_window_types, which is of non-class type int
  366 |   if (iter == known_window_types->end ())
      |                                   ^~~
../../binutils-gdb/gdb/tui/tui-layout.c: In function void initialize_known_windows():
../../binutils-gdb/gdb/tui/tui-layout.c:380:60: error: window_factory was not declared in this scope
  380 |   known_window_types = new std::unordered_map<std::string, window_factory>;
      |                                                            ^~~~~~~~~~~~~~
../../binutils-gdb/gdb/tui/tui-layout.c:380:74: error: template argument 2 is invalid
  380 |   known_window_types = new std::unordered_map<std::string, window_factory>;
      |                                                                          ^
../../binutils-gdb/gdb/tui/tui-layout.c:380:74: error: template argument 5 is invalid
../../binutils-gdb/gdb/tui/tui-layout.c:382:23: error: request for member emplace in * known_window_types, which is of non-class type int
  382 |   known_window_types->emplace ("src",
      |                       ^~~~~~~
../../binutils-gdb/gdb/tui/tui-layout.c:385:23: error: request for member emplace in * known_window_types, which is of non-class type int
  385 |   known_window_types->emplace ("cmd",
      |                       ^~~~~~~
../../binutils-gdb/gdb/tui/tui-layout.c:387:23: error: request for member emplace in * known_window_types, which is of non-class type int
  387 |   known_window_types->emplace ("regs",
      |                       ^~~~~~~
../../binutils-gdb/gdb/tui/tui-layout.c:390:23: error: request for member emplace in * known_window_types, which is of non-class type int
  390 |   known_window_types->emplace ("asm",
      |                       ^~~~~~~
../../binutils-gdb/gdb/tui/tui-layout.c:393:23: error: request for member emplace in * known_window_types, which is of non-class type int
  393 |   known_window_types->emplace ("status", get_locator_window);
      |                       ^~~~~~~
../../binutils-gdb/gdb/tui/tui-layout.c: In function bool validate_window_name(const string&):
../../binutils-gdb/gdb/tui/tui-layout.c:924:35: error: request for member find in * known_window_types, which is of non-class type int
  924 |   auto iter = known_window_types->find (name);
      |                                   ^~~~
../../binutils-gdb/gdb/tui/tui-layout.c:925:38: error: request for member end in * known_window_types, which is of non-class type int
  925 |   return iter != known_window_types->end ();
      |                                      ^~~
make[2]: *** [Makefile:1599: tui/tui-layout.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-4/fedora-x86-64-native-extended-gdbserver-m32/build/gdb'
make[1]: *** [Makefile:10066: all-gdb] Error 2
make[1]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-4/fedora-x86-64-native-extended-gdbserver-m32/build'
make: *** [Makefile:854: all] Error 2
program finished with exit code 2
elapsedTime=382.444787