[PATCH][gdb/testsuite] Handle early_flags in gdb_default_target_compile

[Tom de Vries]

[ was: Re: [PATCH][gdb/testsuite] Limit default_target_compile override ]
On 6/22/20 11:34 PM, Luis Machado wrote:
> Hi,
> 
> This commit seems to have caused a few regressions for aarch64-linux:
> 
> -# of expected passes        75098
> -# of unexpected failures    63
> -# of expected failures        114
> +# of expected passes        75036
> +# of unexpected failures    149
> +# of expected failures        111
> 
> They are distributed across a few different tests:
> 
> gdb.base/display.exp
> gdb.base/jit-reader-simple.exp
> gdb.base/shlib-call.exp
> gdb.base/solib-weak.exp
> gdb.base/step-test.exp
> gdb.base/store.exp
> gdb.base/type-opaque.exp
> gdb.cp/ovldbreak.exp
> gdb.multi/multi-target.exp
> gdb.reverse/step-precsave.exp
> gdb.reverse/step-reverse.exp
> 
> It seems mostly related to missing options in the compilation line. For
> example, display.exp is missing -fno-stack-protector, which leads to a
> different source stepping pattern than the test is actually expecting.
> 

Hi Luis,

thanks for reporting this.

This should be fixed by attached patch.

Any comments?

Thanks,
- Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gdb-testsuite-Handle-early_flags-in-gdb_default_target_compile.patch
Type: text/x-patch
Size: 2048 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/gdb-patches/attachments/20200629/b8657a9b/attachment.bin>