[PATCH v2] Fix -Wstring-compare testcase build failure

Gary Benson gbenson@redhat.com
Fri Jun 26 13:54:20 GMT 2020


Pedro Alves wrote:
> On 6/26/20 2:05 PM, Gary Benson wrote:
> 
> > diff --git a/gdb/testsuite/gdb.cp/try_catch.exp b/gdb/testsuite/gdb.cp/try_catch.exp
> > index fb53294..e4da885 100644
> > --- a/gdb/testsuite/gdb.cp/try_catch.exp
> > +++ b/gdb/testsuite/gdb.cp/try_catch.exp
> > @@ -63,5 +63,8 @@ gdb_continue_to_breakpoint "marker 3-throw"
> >  gdb_breakpoint [gdb_get_line_number "marker 3-catch"]
> >  gdb_continue_to_breakpoint "marker 3-catch"
> >  
> > +gdb_breakpoint [gdb_get_line_number "marker test-complete"]
> > +gdb_test "p test" "= true"
> > +
> 
> You need to continue the program to the breakpoint too.
> I.e., you're missing a
> 
>   gdb_continue_to_breakpoint "marker test-complete"
> 
> line.
> 
> OK with that change.

Fixed and pushed, thanks Pedro.

Cheers,
Gary

-- 
Gary Benson - he / him / his
Principal Software Engineer, Red Hat



More information about the Gdb-patches mailing list