[PATCH] Remove obsolete gdbarch_static_transform_name

[Rainer Orth]

Hi Pedro,

> On 6/25/20 9:26 AM, Rainer Orth wrote:
>>  	case 'X':
>> -	  /* SunPRO (3.0 at least) static variable encoding.  */
>> -	  if (gdbarch_static_transform_name_p (gdbarch))
>> -	    goto normal;
>>  	  /* fall through */
>>  
>
> If you're leaving the 
>
>   case 'X':
>
> then I think you should leave a comment in place about that
> is about.

I thought about that, but I strongly suspect that the comment only
applies to the gdbarch_static_transform_name_p call that is gone now,
not the case as a whole.  I meant to check "Stabs Interface" included
with the Studio compilers (READMEs/stabs.pdf, a quite extensive 170-page
document), but forgot.

> But I'd just remove that case X line, since the fallthrough
> is to the default case anyway.

Right, that's certainly clearer.

Here's the revised version.  Ok now?

Thanks.
        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


2020-06-24  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	gdb:
	* sol2-tdep.c (sol2_static_transform_name): Remove.
	(sol2_init_abi): Don't register it.
	* gdbarch.sh (static_transform_name): Remove.
	* gdbarch.c, gdbarch.h: Regenerate.

	* dbxread.c (read_dbx_symtab) <'S'>: Remove call to
	gdbarch_static_transform_name.
	* mdebugread.c (parse_partial_symbols) <'S'>: Likewise.
	* stabsread.c (define_symbol) <'X'>: Remove.
	(define_symbol) <'S'>: Remove gdbarch_static_transform_name
	handling.
	<'V'>: Likewise.
	* xcoffread.c (scan_xcoff_symtab): Remove gdbarch.
	<'S'>: Remove call to gdbarch_static_transform_name.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: sol2-rm-static_transform_name.patch
Type: text/x-patch
Size: 10563 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/gdb-patches/attachments/20200625/71501c6f/attachment.bin>