[PATCH v2 2/3] gdb/jit: return bool in jit_breakpoint_re_set_internal and jit_read_descriptor

[Aktemur, Tankut Baris]

On Sunday, June 21, 2020 5:44 AM, Simon Marchi wrote:
> On 2020-06-16 5:49 a.m., Tankut Baris Aktemur via Gdb-patches wrote:
> > This is a minor refactoring that converts the return type of
> > jit_read_descriptor and jit_breakpoint_re_set_internal functions
> > from 'int' to 'bool'.
> 
> Please mention that you are reversnig the return value logic of jit_breakpoint_re_set_internal,
> otherwise at first glance it can look like a mistake.
> 
> Otherwise this LGTM, I think you can push it right away.
> 
> Simon

Pushed with that note in the commit message and ChangeLog entry.

Thanks.
-Baris


Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928