[RFC 2/6] Add "help news"
Tom Tromey
tom@tromey.com
Sun Jun 21 20:23:13 GMT 2020
>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
>> +static void
>> +help_news (struct ui_file *stream)
>> +{
>> + std::string news_name = std::string (gdb_datadir) + SLASH_STRING + "NEWS";
>> + gdb_file_up news_file = gdb_fopen_cloexec (news_name.c_str (), "r");
Eli> Is datadir the best place for NEWS? Why not somewhere below docdir?
I looked into this. docdir does seem more correct according to the GNU
coding standards, but on the other hand, making it work properly seems
like a lot of work (adding a new setting and command line option) for
what amounts to a minor conformance thing.
So unless someone feels very strongly about it, I'm inclined to leave it
as is.
>> Btw, I don't see this subcommand described in the manual. Should it
>> be?
Probably but where would be the best place to put it?
Tom
More information about the Gdb-patches
mailing list