[PATCH 26/28] Don't write to inferior_ptid in ravenscar-thread.c

Pedro Alves palves@redhat.com
Thu Jun 18 20:00:07 GMT 2020


On 4/17/20 7:45 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Pedro>    ravenscar_thread_target ()
> Pedro> +    : m_base_ptid (inferior_ptid)
> Pedro>    {
> Pedro> -    update_inferior_ptid ();
> Pedro> +    thread_info *thr = add_active_thread ();
> Pedro> +    if (thr != nullptr)
> Pedro> +      switch_to_thread (thr);
> Pedro>    }
> 
> I wonder if this will help with the announcement problem fixed here:
> 
> https://sourceware.org/pipermail/gdb-patches/2019-March/156455.html
> 

I don't think so.  update_inferior_ptid added a thread, and
add_active_thread will still add it.

> It's not all that important, I still want to try to get that series in.
> It's held up on
> 
> https://sourceware.org/pipermail/gdb-patches/2019-March/156453.html
> 

Offhand that seemed like a gross hack to me when I first saw it, which is
why I've had trouble responding.  :-(  But maybe I just misunderstood it.

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list