TUI enhancement suggestion.

[Pedro Alves]

On 6/15/20 5:56 PM, Phi Debian via Gdb-patches wrote:
> Hi Pedro and all,
> 
> I am really sorry but I lost my bandwith, I am starting a new job tomorow
> leaving little room for investigation etc.
> 
> Regarding the point line, used to be inverse video on monochrome, i thought
> it was kind of bizare with highlighted text because we don't have a uniform
> background color (before patch) then an attempt was made to have a uniform
> background  color but then it monopolized one color that can't be used with
> foreground. The underline suffer the same problem as the inverse video, I.e
> its color change as we highlight text. That's why the little demo only
> underlined the front part of the line, that could be be reverse video too
> but just the whitespace on the front of the line are by definition
> monochrome.  I reckon my demo is bugged as you noticed, when disabling
> syntax highlight then my underline goes all the way through the point line.
> 
> May be an idea could be set the whole point line with un-highlited,
> monochrome,  then with the new range thing use reverse or underline for the
> sub part only

Yeah.  I actually saw some screenshots of IDEs disabling syntax highlighting
in the current highlighted source line the other day, and thought that looks
nice too, and probably a better solution that the underline idea.

E.g., looking around I found this:

 https://forum.unity.com/proxy.php?image=http%3A%2F%2Fpuu.sh%2FpL42e%2F11645e7230.gif&hash=fedb45091f23bfa99b53af562f56ff0c

Try the attached patch, and do "set tui current-line-highlight reverse-mono".

"set tui current-line-highlight reverse-styled" is the same as current GDB:

  https://i.imgur.com/UwX6bfz.png

"set tui current-line-highlight reverse-mono" gives you this:

  https://i.imgur.com/T1DeRum.png

Thanks,
Pedro Alves
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-set-tui-current-line-highlight-mode-reverse-styled-r.patch
Type: text/x-patch
Size: 5156 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/gdb-patches/attachments/20200615/84a88582/attachment.bin>