[PATCH 2/2] guile: Add support for Guile 3.0.

Ludovic Courtès ludo@gnu.org
Mon Jun 15 15:17:08 GMT 2020


Hi,

Tom Tromey <tom@tromey.com> skribis:

>>>>>> "Ludovic" == Ludovic Courtès <ludo@gnu.org> writes:
>
> Ludovic> 	* testsuite/gdb.guile/source2.scm: Add #f first argument to
> Ludovic> 	'format'.
> Ludovic> 	* testsuite/gdb.guile/types-module.exp: Remove "ERROR:" from
> Ludovic> 	regexps since Guile 3.0 no longer prints that.
>
> testsuite/ (unfortunately IMO) has its own ChangeLog.

Oops, will change it.

> Ludovic>        /* If scm_is_unsigned_integer can't work with this type, just punt.  */
> Ludovic> -      if (TYPE_LENGTH (type) > sizeof (scm_t_uintmax))
> Ludovic> +      if (TYPE_LENGTH (type) > sizeof (uintmax_t))
>
> I suppose these can't differ in Guile 2.0 or 2.2?

Correct.  ‘scm_t_uintmax’ used to be provided by Guile but it no longer
makes sense now that C99 <stdint.h> and its C++ counterpart are widely
available.

> Anyway, this patch seems fine to me.

Thanks,
Ludo’.


More information about the Gdb-patches mailing list