On 2020-06-12 3:21 p.m., Pedro Alves wrote: > @@ -4371,21 +4336,54 @@ search_minsyms_for_name (struct collect_info *info, > > if (!minsyms.empty ()) You could remove this check and de-indent the rest. If minsyms is empty, the loop will just be skipped over. Otherwise, LGTM. Simon