[PATCH] Compute proper length for dynamic types of TYPE_CODE_TYPEDEF
Tom de Vries
tdevries@suse.de
Thu Jun 11 12:38:44 GMT 2020
On 11-06-2020 12:46, Pedro Alves wrote:
> On 6/10/20 12:35 PM, Tom de Vries wrote:
>> Hi,
>>
>> [ This patch was submitted earlier here (
>> https://sourceware.org/legacy-ml/gdb-patches/2017-06/msg00679.html ).
>>
>> I've:
>> - made the patch applicable to current master
>> - made the log message narrower
>> - added a missing initialization in the test-case:
>> vla_struct_typedef_struct_member_object.something = n * 2;
>> - renamed things in the test-case as suggested by Pedro's review comments
>> ( https://sourceware.org/legacy-ml/gdb-patches/2017-06/msg00696.html ).
>> - re-tested on x86_64-linux.
>> ]
>>
>>
>> Any comments?
>
> LGTM.
>
Thanks for the review.
I've just realized that Keith submitted a v2 here (
https://sourceware.org/pipermail/gdb-patches/2017-December/145898.html
), so I seem to have duplicated some work.
Anyway, I've copied the comments in the test-case from that version, and
committed.
Thanks,
- Tom
More information about the Gdb-patches
mailing list