[PATCH v2] [gdb] Support frames inlined into the outer frame

[Simon Marchi]

On 2020-06-08 8:00 a.m., Luis Machado wrote:
> 
> I don't see the same, even with the fixup of memcmp. Though gdb.base/break.exp has full passes with the change, the following tests internal error with the patch...
> 
> gdb.mi/mi-nonstop.exp
> gdb.threads/clone-thread_db.exp
> gdb.threads/current-lwp-dead.exp
> gdb.threads/hand-call-in-threads.exp
> gdb.threads/linux-dp.exp
> gdb.threads/local-watch-wrong-thread.exp
> gdb.threads/queue-signal.exp
> gdb.threads/schedlock.exp
> gdb.threads/thread_check.exp
> gdb.threads/tls.exp
> 
> #1  0x0000ffffb7fa1088 in start_thread () from /lib/aarch64-linux-gnu/libpthread.so.0
> ../../../repos/binutils-gdb/gdb/frame.c:551: internal-error: void compute_frame_id(frame_info*): Assertion `frame_id_p (fi->this_id.value)' failed.
> 
> Scott, could you please send a v3 so I can make sure I tested the right version? I was initially slightly confused with what version Simon was talking about since I had already tested v2.

I don't see these tests failing.  Can you please share your test setup?  Maybe we'll find
what's different between us.

I've attached the patch I am testing.  It is just patch v2 with `== 0` added after the
memcmp call.  I am testing on top of commit 7d8b91fda9fed423b91d4d43b19dd068457fe555.  I
am testing on machine gcc117 of the compile farm, which is running Debian 9.12 (stretch).
The gcc version there is 6.3.0.

Simon


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Support-frames-inlined-into-the-outer-frame.patch
Type: text/x-patch
Size: 5754 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/gdb-patches/attachments/20200608/90b1981d/attachment.bin>