[committed][gdb/testsuite] Fix scrolling in gdb.dwarf2/multidictionary.exp

[Tom de Vries]

[ was: Re: [PATCH 5/5] gdb/23712: Test case for multidictionary ]

On 30-11-2018 21:59, Tom Tromey wrote:
>>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
> 
> Keith> This is a test derived from one of the reproducers in symtab/23010.
> Keith> The DIE tree used here is typical of compilations with LTO, where an
> Keith> artificial parent DIE of language C99 imports DIEs of other languages.
> 
> Keith> testsuite/ChangeLog:
> 
> Keith> 	PR gdb/23712
> Keith> 	* gdb.dwarf2/multidictionary.exp: New file.
> 
> Thanks.  This is great.
> 
> Keith> +# We force the DIEs above to be read in via "--readnow".
> Keith> +set saved_gdbflags $GDBFLAGS
> Keith> +append GDBFLAGS " --readnow"
> Keith> +
> Keith> +if {[prepare_for_testing "failed to prepare" $testfile \
> Keith> +        "${asm_file} ${srcfile}" {}]} {
> Keith> +    return -1
> Keith> +}
> Keith> +set GDBFLAGS $saved_gdbflags
> 
> I recently learned about gdb_spawn_with_cmdline_opts -- see
> gdb.base/warning.exp for an example.  I think that's preferable to
> saving and resetting GDBFLAGS.
> 

I ran into another problem in this test-case due to using
gdb_spawn_with_cmdline_opts.

I've fixed this by removing the use of gdb_spawn_with_cmdline_opts, and
temporarily modifying GDBFLAGS instead (using save_vars to restore the
value).

Thanks,
- Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gdb-testsuite-Fix-scrolling-in-gdb.dwarf2-multidictionary.exp.patch
Type: text/x-patch
Size: 2171 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/gdb-patches/attachments/20200602/4ca37bab/attachment.bin>