[PATCH] Fix issues with reading rnglists, especially from dwo files, for DWARF v5

[Tom Tromey]

>>>>> "Caroline" == Caroline Tice via Gdb-patches <gdb-patches@sourceware.org> writes:

Caroline> This patch fixes these issues.  I verified that it fixes the
Caroline> issues I saw and that it does not cause any testsuite
Caroline> regressions (on x86_64 ubuntu linux).

Is there a way to reproduce the failures with the current test suite?
Say, by running some test using some board file?

Caroline> @@ -793,12 +796,18 @@ struct virtual_v2_dwo_sections
Caroline>    bfd_size_type loc_offset;
Caroline>    bfd_size_type loc_size;
 
Caroline> +  bfd_size_type loclists_offset;
Caroline> +  bfd_size_type loclists_size;
Caroline> +
Caroline>    bfd_size_type macinfo_offset;
Caroline>    bfd_size_type macinfo_size;
 
Caroline>    bfd_size_type macro_offset;
Caroline>    bfd_size_type macro_size;
 
Caroline> +  bfd_size_type rnglists_offset;
Caroline> +  bfd_size_type rnglists_size;

These new members don't seem to be used anywhere.

Caroline> +static struct dwarf2_section_info *cu_debug_rnglist_section (struct
Caroline> +							     dwarf2_cu *cu);

Probably better to split before the "(" and then indent the continuation
line 2 spaces.

Caroline> -	default:
Caroline> +        case DW_RLE_startx_endx:

Looks like the indentation here is incorrect.

Caroline> +
Caroline> +  attr =  die->attr (DW_AT_rnglists_base);

Extra space after the "=".

Tom